Peer: we can use async/await for the initial handshake

events.once(emitter, eventname) makes it so much more concise!
This commit is contained in:
Starbeamrainbowlabs 2021-10-09 18:13:34 +01:00
parent 6f181971e3
commit 32dec3049f
Signed by: sbrl
GPG key ID: 1BE5172E637709C2
2 changed files with 28 additions and 22 deletions

View file

@ -1,6 +1,6 @@
"use strict"; "use strict";
import { EventEmitter } from 'events'; import { EventEmitter, once } from 'events';
import Connection from '../transport/Connection.mjs'; import Connection from '../transport/Connection.mjs';
class Peer extends EventEmitter { class Peer extends EventEmitter {
@ -29,40 +29,46 @@ class Peer extends EventEmitter {
// Fetch the remote's id // Fetch the remote's id
} }
///////////////////////////////////////////////////////////////////////////
/** /**
* Accepts an existing connection as a new Peer. * Accepts an existing connection as a new Peer.
* @param {Connection} connection The Connection to accept. * @param {Connection} connection The Connection to accept.
* @return {Promise} A Promise that resolves once the initial handshake is complete. * @return {Promise} A Promise that resolves once the initial handshake is complete.
*/ */
__accept(connection) { async __accept(connection) {
return new Promise((resolve, reject) => { this.connection = connection;
this.connection = connection; const [ msg ] = await once(this.connection, "message-hello");
this.connection.on("message-request-id", (msg) => { this.__handle_hello(msg);
this.connection.id = msg.my_id;
this.connection.send("id", { my_id: this.server.our_id }) this.emit("connect");
.then(resolve, reject);
});
});
} }
/** /**
* Initiates the handshake after opening a new connection. * Initiates the handshake after opening a new connection.
* @return {Promise} A Promise that resolves after the initial peer handshake is complete. * @return {Promise} A Promise that resolves after the initial peer handshake is complete.
*/ */
__initiate() { async __initiate() {
return new Promise((resolve, reject) => { await this.__send_hello();
this.connection.send("request-id", { my_id: this.server.our_id }) const [ msg ] = await once(this.connection, "message-hello");
.then(() => { this.__handle_hello(msg);
this.connection.once("message-id", (msg) => {
this.id = msg.my_id;
this.emit("connect"); this.emit("connect");
resolve(); }
});
}, reject); __handle_hello(msg) {
this.id = msg.id;
}
async __send_hello() {
await this.connection.send("hello", {
id: this.server.our_id,
peers: this.server.peers()
}); });
} }
///////////////////////////////////////////////////////////////////////////
async destroy() { async destroy() {
await this.connection.destroy(); await this.connection.destroy();
this.emit("destroy"); this.emit("destroy");

View file

@ -70,7 +70,7 @@ class PeerServer extends EventEmitter {
* Returns a list of all currently known peer addresses. * Returns a list of all currently known peer addresses.
* @return {{address:string,port:number}[]} * @return {{address:string,port:number}[]}
*/ */
peer_addresses() { peer() {
return this.peers.map((peer) => peer.remote_endpoint) return this.peers.map((peer) => peer.remote_endpoint)
.filter(el => typeof el.addr === "string" && typeof el.port === "number"); .filter(el => typeof el.addr === "string" && typeof el.port === "number");
} }