sbrl-github/Minetest-WorldEditAdditions
1
0
Fork 0
mirror of https://github.com/sbrl/Minetest-WorldEditAdditions.git synced 2024-11-26 09:03:01 +00:00
Code Issues Releases Wiki Activity

//subdivide: no no no. that can't be the problem because worldedit.sort_pos() implicitly clones

Browse source
This commit is contained in:
Starbeamrainbowlabs 2020-06-27 02:05:31 +01:00
parent ce6ed01b36
commit 32b4a84a4a
Signed by: sbrl
GPG key ID: 1BE5172E637709C2
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
worldeditadditions_commands/commands/subdivide.lua
View file

@ -75,10 +75,6 @@ worldedit.register_command("subdivide", {
local time_total = worldeditadditions.get_ms_time() local time_total = worldeditadditions.get_ms_time()
local pos1, pos2 = worldedit.sort_pos(worldedit.pos1[name], worldedit.pos2[name]) local pos1, pos2 = worldedit.sort_pos(worldedit.pos1[name], worldedit.pos2[name])
pos1 = worldeditadditions.shallowcopy(pos1)
pos2 = worldeditadditions.shallowcopy(pos2)
-- TODO: Need to clone pos1 & pos2 here, because pass-by-reference
-- TODO: We should clone further down too, just in case
local volume = worldedit.volume(pos1, pos2) local volume = worldedit.volume(pos1, pos2)
local cmd = worldedit.registered_commands[cmd_name] local cmd = worldedit.registered_commands[cmd_name]