sbrl-github/Pepperminty-Wiki
sbrl-github/Pepperminty-Wiki
1
0
Fork 0
mirror of https://github.com/sbrl/Pepperminty-Wiki.git synced 2024-11-25 17:23:00 +00:00
Code Activity

Squash warnings about non-static methods in the page renderer

Browse source
This commit is contained in:
Starbeamrainbowlabs 2019-09-11 22:11:13 +01:00
parent 2198755af8
commit dcd3c00d83
Signed by: sbrl
GPG key ID: 1BE5172E637709C2
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Changelog.md
View file

@ -20,6 +20,7 @@ This file holds the changelog for Pepperminty Wiki. This is the master list of t
- Hide site logo from screen readers - Hide site logo from screen readers
- Lists of pages that have a specific tag will now be sorted alphabetically (unicode characters should be handled correctly too) - Lists of pages that have a specific tag will now be sorted alphabetically (unicode characters should be handled correctly too)
- Support Unicode characters when sorting. If it's a list of something, then it's now sorted correctly (e.g. includes pages, tags, etc). - Support Unicode characters when sorting. If it's a list of something, then it's now sorted correctly (e.g. includes pages, tags, etc).
- Squashed a bunch of warnings about a non-static methid in the page renderer
### Changed ### Changed
- Made `build.sh` build script more robust, especially when generating the documentation. - Made `build.sh` build script more robust, especially when generating the documentation.

4
core/40-page-renderer.php
View file

@ -342,7 +342,7 @@ class page_renderer
* @package core * @package core
* @param string $scriptUrl The url of the javascript file to reference. * @param string $scriptUrl The url of the javascript file to reference.
*/ */
public function add_js_link(string $scriptUrl) { public static function add_js_link(string $scriptUrl) {
static::$jsLinks[] = $scriptUrl; static::$jsLinks[] = $scriptUrl;
} }
/** /**
@ -350,7 +350,7 @@ class page_renderer
* @package core * @package core
* @param string $script The snippet of javascript to add. * @param string $script The snippet of javascript to add.
*/ */
public function add_js_snippet(string $script) { public static function add_js_snippet(string $script) {
static::$jsSnippets[] = $script; static::$jsSnippets[] = $script;
} }
/** /**