sbrl-github/Pepperminty-Wiki
sbrl-github/Pepperminty-Wiki
1
0
Fork 0
mirror of https://github.com/sbrl/Pepperminty-Wiki.git synced 2024-11-22 16:33:00 +00:00
Code Activity

feature-history: fix potential XSS attack

Browse source
This commit is contained in:
Starbeamrainbowlabs 2021-09-02 22:58:19 +01:00
parent 3f61c9eac0
commit b5b38166ac
Signed by: sbrl
GPG key ID: 1BE5172E637709C2
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/feature-history.php
View file

@ -35,7 +35,7 @@ register_module([
switch($format) { switch($format) {
case "html": case "html":
$content = "<h1>History for $env->page</h1>\n"; $content = "<h1>History for $env->page_safe</h1>\n";
if(!empty($pageindex->{$env->page}->history)) if(!empty($pageindex->{$env->page}->history))
{ {
$content .= "\t\t<ul class='page-list'>\n"; $content .= "\t\t<ul class='page-list'>\n";
@ -163,11 +163,11 @@ register_module([
if($result === false) { if($result === false) {
http_response_code(503); http_response_code(503);
exit(page_renderer::render_main("Server Error - Revert - $settings->sitename", "<p>A server error occurred when $settings->sitename tried to save the reversion of <code>" . htmlentities($env->page) . "</code>. Please contact $settings->sitename's administrator $settings->admindetails_name, whose email address can be found at the bottom of every page (including this one).</p>")); exit(page_renderer::render_main("Server Error - Revert - $settings->sitename", "<p>A server error occurred when $settings->sitename tried to save the reversion of <code>$env->page_safe</code>. Please contact $settings->sitename's administrator $settings->admindetails_name, whose email address can be found at the bottom of every page (including this one).</p>"));
} }
http_response_code(201); http_response_code(201);
exit(page_renderer::render_main("Reverting " . htmlentities($env->page) . " - $settings->sitename", "<p>" . htmlentities($env->page) . " has been reverted back to revision {$env->history->revision_number} successfully.</p> exit(page_renderer::render_main("Reverting $env->page - $settings->sitename", "<p>$env->page_safe has been reverted back to revision {$env->history->revision_number} successfully.</p>
<p><a href='?page=" . rawurlencode($env->page) . "'>Go back</a> to the page, or continue <a href='?action=history&page = " . rawurlencode($env->page) . "'>reviewing its history</a>.</p>")); <p><a href='?page=" . rawurlencode($env->page) . "'>Go back</a> to the page, or continue <a href='?action=history&page = " . rawurlencode($env->page) . "'>reviewing its history</a>.</p>"));
// $env->page_filename // $env->page_filename