sbrl-github/Pepperminty-Wiki
sbrl-github/Pepperminty-Wiki
1
0
Fork 0
mirror of https://github.com/sbrl/Pepperminty-Wiki.git synced 2024-11-25 05:22:59 +00:00
Code Activity

Bugfix: fix crash when attempting to leave a top-level comment

Browse source
This commit is contained in:
Starbeamrainbowlabs 2022-02-06 00:24:55 +00:00
parent 75e2abce0f
commit 439187139d
Signed by: sbrl
GPG key ID: 1BE5172E637709C2
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Changelog.md
View file

@ -9,6 +9,7 @@ This file holds the changelog for Pepperminty Wiki. This is the master list of t
### Fixed ### Fixed
- Stats: Fix crash when loading the stats page - Stats: Fix crash when loading the stats page
- Fix crash when leaving a top-level comment
- [security] Fixed an XSS vulnerability in the `format` GET parameter of the `stats` action (thanks, @JamieSlome) - [security] Fixed an XSS vulnerability in the `format` GET parameter of the `stats` action (thanks, @JamieSlome)
- [security] Ensured that the `returnto` GET parameter leads you only to another place on your Pepperminty Wiki instance (thanks, @JamieSlome) - [security] Ensured that the `returnto` GET parameter leads you only to another place on your Pepperminty Wiki instance (thanks, @JamieSlome)
- [security] Ensure that Javascript in SVGs never gets executed (it's too challenging to strip it, since it could be lurking in many different places - according to [this answer](https://stackoverflow.com/a/68505306/1460422) even Inkscape doesn't strip all Javascript when asked to) - [security] Ensure that Javascript in SVGs never gets executed (it's too challenging to strip it, since it could be lurking in many different places - according to [this answer](https://stackoverflow.com/a/68505306/1460422) even Inkscape doesn't strip all Javascript when asked to)

4
modules/feature-comments.php
View file

@ -5,7 +5,7 @@
register_module([ register_module([
"name" => "Page Comments", "name" => "Page Comments",
"version" => "0.3.4", "version" => "0.3.5",
"author" => "Starbeamrainbowlabs", "author" => "Starbeamrainbowlabs",
"description" => "Adds threaded comments to the bottom of every page.", "description" => "Adds threaded comments to the bottom of every page.",
"id" => "feature-comments", "id" => "feature-comments",
@ -134,7 +134,7 @@ register_module([
"timestamp" => time(), "timestamp" => time(),
"page" => $env->page, "page" => $env->page,
"user" => $env->user, "user" => $env->user,
"reply_depth" => count($comment_thread), "reply_depth" => $comment_thread !== null ? count($comment_thread) : 0,
"comment_id" => $new_comment->id "comment_id" => $new_comment->id
]); ]);
} }