sbrl-github/Pepperminty-Wiki
sbrl-github/Pepperminty-Wiki
1
0
Fork 0
mirror of https://github.com/sbrl/Pepperminty-Wiki.git synced 2024-11-25 17:23:00 +00:00
Code Activity

Nuke all usages of utf8_encode, as I misunderstood what it did.

Browse source
This commit is contained in:
Starbeamrainbowlabs 2018-03-18 16:37:25 +00:00
parent 24efac3c5e
commit 3dc505992d
Signed by: sbrl
GPG key ID: 1BE5172E637709C2
5 changed files with 22 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
build/index.php
View file

@ -1189,19 +1189,19 @@ if(!file_exists($paths->pageindex))
// Create a new entry // Create a new entry
$newentry = new stdClass(); $newentry = new stdClass();
$newentry->filename = utf8_encode(substr( // Store the filename, whilst trimming the storage prefix $newentry->filename = substr( // Store the filename, whilst trimming the storage prefix
$pagefilename, $pagefilename,
strlen(preg_replace("/^\.\//i", "", $env->storage_prefix)) // glob_recursive trim the ./ from returned filenames , so we need to as well mb_strlen(preg_replace("/^\.\//iu", "", $env->storage_prefix)) // glob_recursive trim the ./ from returned filenames , so we need to as well
)); );
// Remove the `./` from the beginning if it's still hanging around // Remove the `./` from the beginning if it's still hanging around
if(substr($newentry->filename, 0, 2) == "./") if(substr($newentry->filename, 0, 2) == "./")
$newentry->filename = substr($newentry->filename, 2); $newentry->filename = substr($newentry->filename, 2);
$newentry->size = filesize($pagefilename); // Store the page size $newentry->size = filesize($pagefilename); // Store the page size
$newentry->lastmodified = filemtime($pagefilename); // Store the date last modified $newentry->lastmodified = filemtime($pagefilename); // Store the date last modified
// Todo find a way to keep the last editor independent of the page index // Todo find a way to keep the last editor independent of the page index
$newentry->lasteditor = utf8_encode("unknown"); // Set the editor to "unknown" $newentry->lasteditor = "unknown"; // Set the editor to "unknown"
// Extract the name of the (sub)page without the ".md" // Extract the name of the (sub)page without the ".md"
$pagekey = utf8_encode(substr($newentry->filename, 0, -3)); $pagekey = mb_substr($newentry->filename, 0, -3);
if(file_exists($env->storage_prefix . $pagekey) && // If it exists... if(file_exists($env->storage_prefix . $pagekey) && // If it exists...
!is_dir($env->storage_prefix . $pagekey)) // ...and isn't a directory !is_dir($env->storage_prefix . $pagekey)) // ...and isn't a directory
@ -1388,7 +1388,7 @@ class ids
$nextid++; $nextid++;
// Update the id index // Update the id index
$idindex->$nextid = utf8_encode($pagename); $idindex->$nextid = $pagename;
// Save the id index // Save the id index
file_put_contents($paths->idindex, json_encode($idindex)); file_put_contents($paths->idindex, json_encode($idindex));
@ -4109,7 +4109,7 @@ class search
public static function index($source) public static function index($source)
{ {
$source = html_entity_decode($source, ENT_QUOTES); $source = html_entity_decode($source, ENT_QUOTES);
$source_length = strlen($source); $source_length = mb_strlen($source);
$index = []; $index = [];
@ -4188,7 +4188,7 @@ class search
$missing_files++; $missing_files++;
continue; continue;
} }
$pagesource = utf8_encode(file_get_contents($page_filename)); $pagesource = Normalizer::normalize(file_get_contents($page_filename), Normalizer::FORM_C);
$index = self::index($pagesource); $index = self::index($pagesource);
$pageid = ids::getid($pagename); $pageid = ids::getid($pagename);
@ -6560,9 +6560,9 @@ DIFFSCRIPT;
$pageindex->{$env->page}->size = strlen($_POST["content"]); $pageindex->{$env->page}->size = strlen($_POST["content"]);
$pageindex->{$env->page}->lastmodified = time(); $pageindex->{$env->page}->lastmodified = time();
if($env->is_logged_in) if($env->is_logged_in)
$pageindex->{$env->page}->lasteditor = utf8_encode($env->user); $pageindex->{$env->page}->lasteditor = $env->user;
else // TODO: Add an option to record the user's IP here instead else // TODO: Add an option to record the user's IP here instead
$pageindex->{$env->page}->lasteditor = utf8_encode("anonymous"); $pageindex->{$env->page}->lasteditor = "anonymous";
$pageindex->{$env->page}->tags = $page_tags; $pageindex->{$env->page}->tags = $page_tags;
// A hack to resave the pagedata if the preprocessors have // A hack to resave the pagedata if the preprocessors have

12
core.php
View file

@ -813,19 +813,19 @@ if(!file_exists($paths->pageindex))
// Create a new entry // Create a new entry
$newentry = new stdClass(); $newentry = new stdClass();
$newentry->filename = utf8_encode(substr( // Store the filename, whilst trimming the storage prefix $newentry->filename = substr( // Store the filename, whilst trimming the storage prefix
$pagefilename, $pagefilename,
strlen(preg_replace("/^\.\//i", "", $env->storage_prefix)) // glob_recursive trim the ./ from returned filenames , so we need to as well mb_strlen(preg_replace("/^\.\//iu", "", $env->storage_prefix)) // glob_recursive trim the ./ from returned filenames , so we need to as well
)); );
// Remove the `./` from the beginning if it's still hanging around // Remove the `./` from the beginning if it's still hanging around
if(substr($newentry->filename, 0, 2) == "./") if(substr($newentry->filename, 0, 2) == "./")
$newentry->filename = substr($newentry->filename, 2); $newentry->filename = substr($newentry->filename, 2);
$newentry->size = filesize($pagefilename); // Store the page size $newentry->size = filesize($pagefilename); // Store the page size
$newentry->lastmodified = filemtime($pagefilename); // Store the date last modified $newentry->lastmodified = filemtime($pagefilename); // Store the date last modified
// Todo find a way to keep the last editor independent of the page index // Todo find a way to keep the last editor independent of the page index
$newentry->lasteditor = utf8_encode("unknown"); // Set the editor to "unknown" $newentry->lasteditor = "unknown"; // Set the editor to "unknown"
// Extract the name of the (sub)page without the ".md" // Extract the name of the (sub)page without the ".md"
$pagekey = utf8_encode(substr($newentry->filename, 0, -3)); $pagekey = mb_substr($newentry->filename, 0, -3);
if(file_exists($env->storage_prefix . $pagekey) && // If it exists... if(file_exists($env->storage_prefix . $pagekey) && // If it exists...
!is_dir($env->storage_prefix . $pagekey)) // ...and isn't a directory !is_dir($env->storage_prefix . $pagekey)) // ...and isn't a directory
@ -1012,7 +1012,7 @@ class ids
$nextid++; $nextid++;
// Update the id index // Update the id index
$idindex->$nextid = utf8_encode($pagename); $idindex->$nextid = $pagename;
// Save the id index // Save the id index
file_put_contents($paths->idindex, json_encode($idindex)); file_put_contents($paths->idindex, json_encode($idindex));

4
module_index.json
View file

@ -104,7 +104,7 @@
"author": "Starbeamrainbowlabs", "author": "Starbeamrainbowlabs",
"description": "Adds proper search functionality to Pepperminty Wiki using an inverted index to provide a full text search engine. If pages don't show up, then you might have hit a stop word. If not, try requesting the `invindex-rebuild` action to rebuild the inverted index from scratch.", "description": "Adds proper search functionality to Pepperminty Wiki using an inverted index to provide a full text search engine. If pages don't show up, then you might have hit a stop word. If not, try requesting the `invindex-rebuild` action to rebuild the inverted index from scratch.",
"id": "feature-search", "id": "feature-search",
"lastupdate": 1521389882, "lastupdate": 1521390977,
"optional": false "optional": false
}, },
{ {
@ -167,7 +167,7 @@
"author": "Starbeamrainbowlabs", "author": "Starbeamrainbowlabs",
"description": "Allows you to edit pages by adding the edit and save actions. You should probably include this one.", "description": "Allows you to edit pages by adding the edit and save actions. You should probably include this one.",
"id": "page-edit", "id": "page-edit",
"lastupdate": 1518645807, "lastupdate": 1521390769,
"optional": false "optional": false
}, },
{ {

4
modules/feature-search.php
View file

@ -509,7 +509,7 @@ class search
public static function index($source) public static function index($source)
{ {
$source = html_entity_decode($source, ENT_QUOTES); $source = html_entity_decode($source, ENT_QUOTES);
$source_length = strlen($source); $source_length = mb_strlen($source);
$index = []; $index = [];
@ -588,7 +588,7 @@ class search
$missing_files++; $missing_files++;
continue; continue;
} }
$pagesource = utf8_encode(file_get_contents($page_filename)); $pagesource = Normalizer::normalize(file_get_contents($page_filename), Normalizer::FORM_C);
$index = self::index($pagesource); $index = self::index($pagesource);
$pageid = ids::getid($pagename); $pageid = ids::getid($pagename);

4
modules/page-edit.php
View file

@ -424,9 +424,9 @@ DIFFSCRIPT;
$pageindex->{$env->page}->size = strlen($_POST["content"]); $pageindex->{$env->page}->size = strlen($_POST["content"]);
$pageindex->{$env->page}->lastmodified = time(); $pageindex->{$env->page}->lastmodified = time();
if($env->is_logged_in) if($env->is_logged_in)
$pageindex->{$env->page}->lasteditor = utf8_encode($env->user); $pageindex->{$env->page}->lasteditor = $env->user;
else // TODO: Add an option to record the user's IP here instead else // TODO: Add an option to record the user's IP here instead
$pageindex->{$env->page}->lasteditor = utf8_encode("anonymous"); $pageindex->{$env->page}->lasteditor = "anonymous";
$pageindex->{$env->page}->tags = $page_tags; $pageindex->{$env->page}->tags = $page_tags;
// A hack to resave the pagedata if the preprocessors have // A hack to resave the pagedata if the preprocessors have