sbrl-github/Air-Quality-Web
1
0
Fork 0
mirror of https://github.com/ConnectedHumber/Air-Quality-Web synced 2024-12-22 10:25:01 +00:00
Code Issues Releases Wiki Activity

Fill out mesurement type repo methods

Browse source
This commit is contained in:
Starbeamrainbowlabs 2019-01-15 15:57:39 +00:00
parent cef578d7eb
commit dea95716ed
Signed by: sbrl
GPG key ID: 1BE5172E637709C2
3 changed files with 17 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
logic/Repositories/IMeasurementTypeRepository.php
View file

@ -8,14 +8,14 @@ interface IMeasurementTypeRepository {
* @param string $type_name The name of the type to validate.
* @return boolean Whether the specified type name is valid or not.
*/
public function is_valid_type(string $type_name);
public function is_valid_type(string $type_name) : boolean;
/**
* Gets the friendly name for the specified type name.
* @param string $type_name The type name to get the friendly name for.
* @return string The friendly name for the specified type name.
*/
public function get_friendly_name(string $type_name);
public function get_friendly_name(string $type_name) : boolean;
/**
* Returns all the currently known meeasurement types.

2
logic/Repositories/MariaDBMeasurementDataRepository.php
View file

@ -61,6 +61,6 @@ class MariaDBMeasurementDataRepository implements IMeasurementDataRepository {
"datetime" => $datetime,
"reading_type" => $reading_type
]
);
)->fetchAll();
}
}

18
logic/Repositories/MariaDBMeasurementTypeRepository.php
View file

@ -25,15 +25,25 @@ class MariaDBMeasurementTypeRepository implements IMeasurementTypeRepository {
public function is_valid_type(string $type_name) {
throw new Exception("Error: Not implemented yet :-\\");
public function is_valid_type(string $type_name) : boolean {
return !empty($this->database->query(
"SELECT $this->column_id FROM $this->table_name;",
[]
)->fetchColumn());
}
public function get_friendly_name(string $type_name) {
public function get_friendly_name(string $type_name) : string {
return $this->database->query(
"SELECT $this->column_friendly_text FROM $this->table_name WHERE $this->column_id = :type_name;", [
"type_name" => $type_name
]
)->fetchColumn();
// TODO: Cache results here? Maybe https://packagist.org/packages/thumbtack/querycache will be of some use
throw new Exception("Error: Not implemented yet :-\\");
}
public function get_all_types() {
throw new Exception("Error: Not implemented yet :-\\");
return $this->database->query(
"SELECT * FROM $this->table_name"
)->fetchAll();
}
}