sbrl-github/Air-Quality-Web
1
0
Fork 0
mirror of https://github.com/ConnectedHumber/Air-Quality-Web synced 2024-12-22 10:25:01 +00:00
Code Issues Releases Wiki Activity

Improve device last seen time performance via new DB column.

Browse source 
Fixes #58
This commit is contained in:
Starbeamrainbowlabs 2019-11-12 22:03:35 +00:00
parent 6425f31743
commit 35c65f4b81
Signed by: sbrl
GPG key ID: 1BE5172E637709C2
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Changelog.md
View file

@ -8,7 +8,8 @@ This is the changelog for the air quality web interface and its associated HTTP
- `[Docs]` refers to changes to the [documentation](https://aq.connectedhumber.org/__nightdocs/00-Welcome.html).
## v0.13.2
- Improve performance of device graph popup
- Improve performance of device graph pop-up
- Improve performance of device last seen times by taking advantage of new database column
## v0.13.1

7
logic/Repositories/MariaDBDeviceRepository.php
View file

@ -21,6 +21,7 @@ class MariaDBDeviceRepository implements IDeviceRepository {
public static $column_long = "device_longitude";
public static $column_point = "lat_lon";
public static $column_altitude = "device_altitude";
public static $column_last_seen = "last_seen";
public static $table_name_type = "device_types";
public static $column_type_id = "device_type";
@ -86,7 +87,7 @@ class MariaDBDeviceRepository implements IDeviceRepository {
{$s("table_name")}.{$s("column_long")} AS longitude,
{$s("table_name")}.{$s("column_altitude")} AS altitude,
{$s("table_name")}.{$s("column_device_type")} AS type_id,
MAX($data_repo_col_datetime) AS last_seen
{$s("table_name")}.{$s("column_last_seen")} AS last_seen
FROM {$s("table_name")}
JOIN $data_repo_table_meta ON
$data_repo_col_device_id = {$s("table_name")}.{$s("column_device_id")}";
@ -119,7 +120,7 @@ class MariaDBDeviceRepository implements IDeviceRepository {
{$s("table_name")}.{$s("column_long")} AS longitude,
{$s("table_name")}.{$s("column_altitude")} AS altitude,
{$s("table_name_type")}.*,
MAX($data_repo_col_datetime) AS last_seen
{$s("table_name")}.{$s("column_last_seen")} AS last_seen
FROM {$s("table_name")}
JOIN {$s("table_name_type")} ON
{$s("table_name")}.{$s("column_device_type")} = {$s("table_name_type")}.{$s("column_type_id")}
@ -160,7 +161,7 @@ class MariaDBDeviceRepository implements IDeviceRepository {
{$s("table_name")}.{$s("column_lat")} AS latitude,
{$s("table_name")}.{$s("column_long")} AS longitude,
ST_DISTANCE_SPHERE(POINT(:latitude, :longitude), {$s("table_name")}.{$s("column_point")}) AS distance_calc,
MAX($data_repo_col_datetime) AS last_seen
{$s("table_name")}.{$s("column_last_seen")} AS last_seen
FROM {$s("table_name")}
JOIN $data_repo_table_meta ON
$data_repo_col_device_id = {$s("table_name")}.{$s("column_device_id")}