sbrl-github/Minetest-WorldEditAdditions
1
0
Fork 0
mirror of https://github.com/sbrl/Minetest-WorldEditAdditions.git synced 2024-11-29 18:33:01 +00:00
Code Issues Releases Wiki Activity

core.param2: add todo reimplement notice

Browse source 
Ref https://discord.com/channels/1135598362821935254/1247681375935533119

---------------------------------------

Hi, a wild //orient+ appeared! While it (probably) doesn't crash, it also unfortunately doesn't work yet.

This is because facedir e.g. points towards the direction the node is pointing, and minetest.facedir_to_dir doesn't capture all the nuance of how the node is pointing, and e.g. if a node is pointing +y and you want to rotate by (0, 90, 0) [degrees], then the current implementation won't do anything.

Then I decided that this is silly and there has to be a solution. After all, screwdriver2 has a great implementation! https://content.minetest.net/packages/12Me21/screwdriver2/

....then I found this lookup table in their codebase: https://github.com/12Me21/screwdriver2/blob/master/init.lua#L75-L79

....aaaaarrrggggghhhhh //orient+ is such a pain to implement!

and my existing implementation is so neat 😢 1dd073f14b/worldeditadditions_core/utils/param2.lua

so, in other words, although I've implemented //orient+ I'm going to have to reimplement the nuts-and-bolts function that does the rotation, which may make it slightly more complicated and annoying to implement support for nodes with param2 types other than facedir.

/rant about Minetest's param2 value and rotations 😛
This commit is contained in:
Starbeamrainbowlabs 2024-06-05 00:14:17 +01:00
parent 080a5a9377
commit e2167c4ba3
Signed by: sbrl
GPG key ID: 1BE5172E637709C2
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
worldeditadditions_core/utils/param2.lua
View file

@ -3,6 +3,8 @@ local Vector3 = core.Vector3
--- ---
-- @module worldeditadditions_core.param2 -- @module worldeditadditions_core.param2
-- TODO Reimplement for facedir ref https://github.com/12Me21/screwdriver2/blob/master/init.lua#L75-L79
-- //set <nodename> -- //set <nodename>
-- //set param2|p2 <param2> -- //set param2|p2 <param2>
@ -25,6 +27,7 @@ local function dir_to_param2(param2_type, dir)
end end
--- Rotates the given param2 value of the given type by the given COMPILED list of rotations. --- Rotates the given param2 value of the given type by the given COMPILED list of rotations.
-- In other words, reorients a given param2 value of a given param2_type (aka paramtype2 in the Minetest engine but the Minetest engine naming scheme is dumb in this case) according to a given COMPILED rotation list. -- In other words, reorients a given param2 value of a given param2_type (aka paramtype2 in the Minetest engine but the Minetest engine naming scheme is dumb in this case) according to a given COMPILED rotation list.
-- @param param2 number The param2 value to rotate. -- @param param2 number The param2 value to rotate.