From e5303d62f07fd8df825683ee779c20049e07cefd Mon Sep 17 00:00:00 2001 From: Starbeamrainbowlabs Date: Thu, 9 May 2019 11:41:35 +0100 Subject: [PATCH] Bugfix: Correct and document GenerateCSSGradient(). --- client_src/js/Helpers/GradientHelpers.mjs | 15 ++++++++++----- lantern-build-engine | 2 +- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/client_src/js/Helpers/GradientHelpers.mjs b/client_src/js/Helpers/GradientHelpers.mjs index 98e05cd..9ded45c 100644 --- a/client_src/js/Helpers/GradientHelpers.mjs +++ b/client_src/js/Helpers/GradientHelpers.mjs @@ -3,19 +3,24 @@ function RenderGradient(stops, max) { let result = {}; - for(let value in stops) { + for(let value in stops) result[value / max] = stops[value]; - } return result; } -function GenerateCSSGradient(stops, max) { +/** + * Generates a CSS gradient, given the output of RenderGradient(). + * @param {[string, string]} stops The stops specification to create a css linear-gradient from. Should be the output of RenderGradient(). + * @returns {string} The rendered CSS linear-gradient. + */ +function GenerateCSSGradient(stops) { let stops_processed = []; for(let value in stops) { - stops_processed = `${stops[value]} ${(value/max).toFixed(3)}%` + let valueNumber = parseFloat(value); + stops_processed.push(`${stops[value]} ${(valueNumber*100).toFixed(3).replace(/\.?[0]+$/, "")}%`); } return `linear-gradient(to bottom, ${stops_processed.join(", ")})`; } -export { RenderGradient }; +export { RenderGradient, GenerateCSSGradient }; diff --git a/lantern-build-engine b/lantern-build-engine index 617fcdb..aaa2463 160000 --- a/lantern-build-engine +++ b/lantern-build-engine @@ -1 +1 @@ -Subproject commit 617fcdb5b9df7f57ccb6639a87be68238f99b9ed +Subproject commit aaa2463547d87e01c650815d0778368cce047b0a